-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/1.2.45 #1047
Release/1.2.45 #1047
Conversation
WalkthroughThe changes in this pull request involve updates across several documentation files and properties to reflect the new version Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (3)
🔇 Additional comments (2)lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java (1)
The version update in the agent string test assertion correctly reflects the new version 1.2.45. Let's verify version consistency across the codebase: ✅ Verification successfulVersion update is consistent across the codebase The version has been correctly updated from 1.2.44 to 1.2.45 in all relevant files:
The only remaining references to 1.2.44 are in the CHANGELOG.md file, which is expected as it maintains the version history. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify that version 1.2.45 is consistently used across the codebase
# and no old version references remain
# Check for any remaining references to the old version
rg "1\.2\.44"
# Check for consistency of new version references
rg "1\.2\.45"
# Check version references in key files
for file in README.md CHANGELOG.md CONTRIBUTING.md gradle.properties; do
if [ -f "$file" ]; then
echo "=== $file ==="
rg "1\.2\.(44|45)" "$file"
fi
done
Length of output: 2152 CONTRIBUTING.md (1)
The AAR file version update from 1.2.44 to 1.2.45 aligns with the release version mentioned in the PR title and changes described in the AI summary. Let's verify version consistency across documentation: ✅ Verification successfulVersion update is consistently applied across all documentation files All version references have been updated from 1.2.44 to 1.2.45 in:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check version consistency across documentation files
# Expected: All version references should be 1.2.45
echo "Checking version references in documentation files..."
rg --type md "1\.2\.(44|45)"
echo "Checking version in gradle.properties..."
rg "VERSION_NAME.*1\.2\.(44|45)" "gradle.properties"
Length of output: 881 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for approval ! |
Summary by CodeRabbit
New Features
1.2.45
, detailing closed issues and merged pull requests.Documentation
CONTRIBUTING.md
with clearer instructions and updated version references.README.md
to reflect the latest version1.2.45
for dependencies.Chores
gradle.properties
from1.2.44
to1.2.45
.